Improve performance of TimeEfficientLongestCommonSubsequenceCalculator
#119
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after #118 I measured the same workload with
TimeEfficientLongestCommonSubsequenceCalculator
.turns out it also bottlenecks on
max()
:before this PR
TimeEfficientLongestCommonSubsequenceCalculator
is even slower thenMemoryEfficientLongestCommonSubsequenceCalculator
in this workload.using the same approach we can see solid performance improvement with this PR and
TimeEfficientLongestCommonSubsequenceCalculator
is similar fast asMemoryEfficientLongestCommonSubsequenceCalculator
but using way more memory: