Skip to content

Improve performance of TimeEfficientLongestCommonSubsequenceCalculator #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2023

Conversation

staabm
Copy link
Contributor

@staabm staabm commented May 1, 2023

after #118 I measured the same workload with TimeEfficientLongestCommonSubsequenceCalculator.

turns out it also bottlenecks on max():

grafik

before this PR TimeEfficientLongestCommonSubsequenceCalculator is even slower then MemoryEfficientLongestCommonSubsequenceCalculator in this workload.

using the same approach we can see solid performance improvement with this PR and TimeEfficientLongestCommonSubsequenceCalculator is similar fast as MemoryEfficientLongestCommonSubsequenceCalculator but using way more memory:

grafik

@codecov
Copy link

codecov bot commented May 1, 2023

Codecov Report

Merging #119 (26d4b0f) into main (57a71cc) will decrease coverage by 0.18%.
The diff coverage is 88.88%.

@@             Coverage Diff              @@
##               main     #119      +/-   ##
============================================
- Coverage     99.45%   99.28%   -0.18%     
- Complexity      202      205       +3     
============================================
  Files            12       12              
  Lines           555      559       +4     
============================================
+ Hits            552      555       +3     
- Misses            3        4       +1     
Impacted Files Coverage Δ
...imeEfficientLongestCommonSubsequenceCalculator.php 96.96% <88.88%> (-3.04%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sebastianbergmann sebastianbergmann merged commit b0a1aad into sebastianbergmann:main May 1, 2023
@staabm staabm deleted the patch-1 branch May 1, 2023 07:46
@sebastianbergmann sebastianbergmann changed the title Improve performance of TimeEfficientLongestCommonSubsequenceCalculator Improve performance of TimeEfficientLongestCommonSubsequenceCalculator May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants