Sync with 3.29.0 #406
Merged
Sync with 3.29.0 #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkropachev
force-pushed
the
dk/sync-with-3.29.0
branch
3 times, most recently
from
270d2f5 to
d9ffed0
Compare
dkropachev
force-pushed
the
dk/sync-with-3.29.0
branch
from
d9ffed0 to
6d08a73
Compare
dkropachev
force-pushed
the
dk/sync-with-3.29.0
branch
2 times, most recently
from
e0f3caf to
85999e3
Compare
dkropachev
force-pushed
the
dk/sync-with-3.29.0
branch
11 times, most recently
from
1eedd4a to
5d0a93d
Compare
dkropachev
force-pushed
the
dk/sync-with-3.29.0
branch
from
5d0a93d to
2245492
Compare
dkropachev
force-pushed
the
dk/sync-with-3.29.0
branch
4 times, most recently
from
7ef3a9c to
3c06734
Compare
dkropachev
force-pushed
the
dk/sync-with-3.29.0
branch
2 times, most recently
from
551f37f to
85a40ba
Compare
Original commit c9b24b7 made it not install certain modules on python 3.13 because at the time python was broken and did not support these modules, now they work ok, roll it back.
dkropachev
force-pushed
the
dk/sync-with-3.29.0
branch
from
85a40ba to
68bf8a7
Compare
|
Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync with 3.29.0 of the upstream
One significant refactor needed to make it work, after c44e264 multiple test become broken, this commit introduced
DependencyExceptionfor missing requirements forasyncorereactor.pyandlibevreactor.pyand partially patched code thatimports them, as result many tests where broken.
I have created following up commit that addresses all the problems: 47d882d
Pre-review checklist
I have provided docstrings for the public items that I want to introduce.I have adjusted the documentation in./docs/source/.I added appropriateFixes:annotations to PR description.