Skip to content

4.x: enforce ccm version #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

dkropachev
Copy link
Collaborator

@dkropachev dkropachev commented May 30, 2025

Recent changes in CCM broke our CICD, let's roll it back to older version.

@dkropachev dkropachev requested a review from Bouncheck May 30, 2025 17:05
@dkropachev dkropachev changed the title cicd: enforce ccm version 4.x: enforce ccm version May 30, 2025
@Lorak-mmk
Copy link

Why not revert / fix ccm instead?

@dkropachev
Copy link
Collaborator Author

Why not revert / fix ccm instead?

It needs to be done, but in CCM repo, what needs to be done here - lock CCM version to one that works

@Lorak-mmk
Copy link

Lorak-mmk commented May 30, 2025

lock CCM version to one that works

And then keep it locked because no one remembers to update, and accrue debt, which will at some point make it too difficult to update ever again.

If other projects do this too, then at some point new CCM versions will probably become completely broken too because no one will test them.

@Lorak-mmk
Copy link

Lorak-mmk commented May 30, 2025

Reverting broken CCM PR should not be more diffucult than pinning here, and will solve the issue for both this project and others that encounter it.

@dkropachev
Copy link
Collaborator Author

Reverting broken CCM PR should not be more diffucult than pinning here, and will solve the issue for both this project and others that encounter it.

It is not clear what exactly is broken in CCM, by some reason only shard awarness tests are failing, there are 4 commits, none of them looks like one.
But it beside the point, it needs to be pegged to have some stability here.

@dkropachev
Copy link
Collaborator Author

lock CCM version to one that works

And then keep it locked because no one remembers to update, and accrue debt, which will at some point make it too difficult to update ever again.

If other projects do this too, then at some point new CCM versions will probably become completely broken too because no one will test them.

We will update it when we need it, if it works, why bother ?

Copy link
Collaborator

@Bouncheck Bouncheck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work better with CI. I think the consensus around AddedNodeIT was that it's flaky, but I don't know why micrometer test breaks.

I have to agree though that if we move to locked version we will stop noticing breaking changes in master and it will be harder to fix.

@Lorak-mmk
Copy link

We will update it when we need it, if it works, why bother ?

We will need to update at some point (for example because older versions may stop working correctly with new Scylla versions). Then it may be much harder to update, because we'll have X months/years of unnoticed errors.
Right now it is enough to revert a broken PR (even if we don't know why it is broken). After a lot of time, we will instead hunt totally unknown errors.

@dkropachev dkropachev closed this Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants