-
Notifications
You must be signed in to change notification settings - Fork 60
It adds the ability to cancel multiple jobs #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 minor change to the logic for validating the input but otherwise it looks good; clear, well commented and documented
👍
c14fd4a
to
3aac98e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can only ask for the same minor change mentioned by Ruairi, feel free to add tests. Well done 👍
3aac98e
to
943f3f6
Compare
943f3f6
to
aea1b17
Compare
Hello guys @vshlapakov @ruairif , |
WIP: It is missing tests.
aea1b17
to
770d39e
Compare
Codecov Report
@@ Coverage Diff @@
## master #125 +/- ##
==========================================
- Coverage 93.61% 93.59% -0.03%
==========================================
Files 28 28
Lines 1895 1919 +24
==========================================
+ Hits 1774 1796 +22
- Misses 121 123 +2
Continue to review full report at Codecov.
|
No description provided.