Skip to content

Make plugin depend on coverageEnabled setting, allow changing runtime scoverage version, add support for Scala.js #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Conversation

lustefaniak
Copy link
Contributor

No description provided.

@lustefaniak
Copy link
Contributor Author

Required changes to scalac-scoverage-runtime cross compile are here: scoverage/scalac-scoverage-plugin#158

@vpavkin
Copy link

vpavkin commented Aug 22, 2016

Am I correct -- this one is waiting for a release of https://github.com/scoverage/scalac-scoverage-plugin that includes scoverage/scalac-scoverage-plugin#158 ?

@lustefaniak
Copy link
Contributor Author

Yes, after cross-compiled scalac-scoverage-plugin is released I can alter
version used in that PR.

pon., 22.08.2016, 11:53 użytkownik Pavkin Vladimir notifications@github.com
napisał:

Am I correct -- this one is waiting for a release of
https://github.com/scoverage/scalac-scoverage-plugin that includes
scoverage/scalac-scoverage-plugin#158
scoverage/scalac-scoverage-plugin#158 ?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#166 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAKzk4mtw57j7srHvrLpiuvMblRmA4gtks5qiXGXgaJpZM4H69EE
.

@gslowikowski
Copy link
Member

@lustefaniak can you contact me via email?

@xerial xerial mentioned this pull request Sep 13, 2016
3 tasks
@gslowikowski
Copy link
Member

@lustefaniak, please create two new seperate PRs based on current repo state:

  1. "Add support for scala.js runtime" based on commit
    2c1e7bb
  2. "Add coveragePluginVersion key" based on commit
    5ce2e34
    but use coverageScalacPluginVersion key name instead of coveragePluginVersion

Remaining commits:
b91fcc8
9bc108c
3c738d2
are not required anymore, because this functionality is already merged from #168

@lustefaniak
Copy link
Contributor Author

Added as #183 and #184

@lustefaniak lustefaniak deleted the simplified-coverage-enabled-handling branch September 19, 2016 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants