Skip to content

Some fixes and a performance enhancement #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 6, 2015
Merged

Some fixes and a performance enhancement #36

merged 8 commits into from
Feb 6, 2015

Conversation

maiflai
Copy link
Contributor

@maiflai maiflai commented Feb 5, 2015

Temporary fixes

  • Work around gradle scalac incompatibilities (until the upstream fixes are released)
  • Remove use of buildscript classpath which is known not to work with multi-module projects

Permanent changes

  • Mark the measured statement file as a compilation output, forcing a recompile if it is missing
  • Reduce build overhead by removing the unused compilation of the main source set

@Kwestor
Copy link
Contributor

Kwestor commented Feb 6, 2015

LGTM, thanks for your work on this plugin, I really appreciate it 👍

maiflai added a commit that referenced this pull request Feb 6, 2015
@maiflai
Merge pull request #36 from maiflai/bob
9ad6178 
Some fixes and a performance enhancement
@maiflai maiflai merged commit 9ad6178 into scoverage:master Feb 6, 2015
@maiflai maiflai deleted the bob branch February 6, 2015 22:44
@maiflai
Copy link
Contributor Author

maiflai commented Feb 6, 2015

Cheers - I'll do some more local testing and look to release this shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maiflai @Kwestor