Skip to content

Support scoverage 1.0 #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 21, 2014
Merged

Conversation

maiflai
Copy link
Contributor

@maiflai maiflai commented Dec 7, 2014

The underlying scalac plugin has changed; this introduces a breaking change to the gradle plugin.

Also includes an attempt to determine a build version from the nearest git tag (should simplify the release process)

@@ -31,7 +40,7 @@ configurations {
dependencies {
compile gradleApi()
compile localGroovy()
scoverage 'org.scoverage:scalac-scoverage-plugin_2.10:0.99.5'
scoverage 'org.scoverage:scalac-scoverage-plugin_2.11:1.0.1','org.scoverage:scalac-scoverage-plugin_2.11:1.0.1'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have plugin here twice, did you meant runtime in second case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot! Interestingly enough, no - I shouldn't have added the runtime dependency at all, it's not required here. I think I accidentally edited this file when I meant to edit the gradle build that is used for testing...

The plugin is compiled against a version of the scalac plugin, but then doesn't expose this dependency downstream; this is the reasoning behind not adding it directly to the compile configuration.

In hindsight I wonder if it would be helpful to provide a default configuration rather than forcing users to state the scoverage version.

I'm going to try to rebase this pull request, so this comment may disappear, or I may have to start a new one...

…ust be also be supplied on the classpath

2) testing instrumented code does not require the plugin jar
3) reporting on coverage files requires all scoverage jars.
@maiflai maiflai closed this Dec 21, 2014
@maiflai maiflai reopened this Dec 21, 2014
sksamuel added a commit that referenced this pull request Dec 21, 2014
@sksamuel sksamuel merged commit 378217e into scoverage:master Dec 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants