Make the plugin compatible with Palantir's consistent versions plugin #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…adle-consistent-versions' plugin (test currently fails)
… configuration time
…y configured by the `scoverageScalaVersion` option
|
Any chance we could get this merged? |
|
@maiflai care to take a look? :) |
|
thanks both - there seems to be recent activity upstream, is it ok to wait for a little bit to see if a release is coming out there? |
|
What's the timeline for that? I work on a large monorepo which would greatly benefit from the performance improvements that this change would provide, so would vote for a release sooner rather than later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #140.
This PR introduces a small change in behavior. The Scala version of the scoverage dependencies will now only be automatically detected if the
scoverageScalaVersionis not defined. Previously, it overrided that option regardless if it was defined or not.Note the changes to the
README.mdfile explaining how to make a build compatible with the Palantir plugin (need to manually configure the Scala version viascoverageScalaVersion).