Cannot cast object 'org.scoverage.ScoverageExtension_Decorated@70bf1425'

[eyalroth]

In a multi-module project, defining the aggregation task must be made in the build.gradle and cannot be extracted to a separate script file.

The following configuration:

build.gradle:

plugins {
    id "org.scoverage" version "2.5.0" apply false
}
apply from: new File(rootProject.projectDir, "gradle/scoverage.gradle")

gradle/scoverage.gradle:

buildscript {
    repositories {
        maven {
            url "https://plugins.gradle.org/m2/"
        }
    }

    dependencies {
        // necessary for resolving 'org.scoverage.ScoverageAggregate'
        classpath group: 'gradle.plugin.org.scoverage', name: 'gradle-scoverage', version: '2.5.0'
    }
}

task aggregateScoverage(type: org.scoverage.ScoverageAggregate)

Will cause this exception upon execution of aggregateScoverage:

 Caused by: org.codehaus.groovy.runtime.typehandling.GroovyCastException: Cannot cast object 'org.scoverage.ScoverageExtension_Decorated@70bf1425' with class 'org.scoverage.ScoverageExtension_Decorated' to class 'org.scoverage.ScoverageExtension'
        at org.scoverage.ScoveragePlugin.extensionIn(ScoveragePlugin.groovy:22)
        at org.scoverage.ScoverageAggregate.exec(ScoverageAggregate.groovy:12)

There are two problems here:

1. The incorrect reading of properties from within tasks. ScoveragePlugin#extensionIn is not the correct way of reading configuration from the extension. See Gradle's official guide on how to map extension properties to task properties.
2. Users shouldn't be bothered with defining the aggregation task on their own, which requires the entire buildscript section unless the definition is in the main build.gradle file. The task should be defined by default upon applying the plugin, much like the other tasks.

[maiflai]

Thanks - I'll take a look at the best practice link.

On the second point - this was originally to avoid to creating an aggregation task for every project. My personal use case was to create one overall report, so defining the task at the root project seemed straightforward.

Is this related to your java+scala work? I suppose that in a mixed project it might be useful to aggregrate at different levels?

[eyalroth]

@maiflai Yep, related to that work 😃

I don't know about having aggregation on different levels. I'd assume it's worth to simply define an aggregation task by default which no other task is depending on, and perhaps if naming it scoverage 😆

[maiflai]

Yes - but that then means that the trivial single project case now runs an unnecessary aggregation?

I'll see what I can come up with.

[eyalroth]

@maiflai It won't run it if the user won't ask for it.

[eyalroth]

@maiflai I'm actually working on fixing this at the moment, alongside removing the requirement of explicitly declaring the scoverage scalac dependencies.

[maiflai]

ah - specifying the scoverage dependencies is a deliberate choice. I don't want to release a new version of the gradle plugin for every upstream release.

I also don't want to automatically take upstream releases.

[eyalroth]

@maiflai That's totally fine. The gradle plugin should use 1.3.1 by default, but allow the version to be configurable via an extension property; for instance:

scoverage {
  scoverageVersion = '1.3.9'
}

[maiflai]

Has this been resolved by the 3.0.0 release please?

Thanks,
Stu

[eyalroth]

Has this been resolved by the 3.0.0 release please?

Thanks,
Stu

Yes :)