Deal with disable option on create #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This wasn't really supposed to be a PR on your fork :/ |
| @@ -175,16 +175,22 @@ return $.widget( "ui.accordion", { | |||
| } | |||
| } | |||
|
|
|||
| if ( key === "disabled" ) { | |||
| this._setOptionDisabled( value ); | |||
| } | |||
There was a problem hiding this comment.
This already happens in the call to ._super() above.
|
For tabs, you should be able to just rename |
Without this, _on will still respect the disabled option and ends up preventing closing the dialog. Ref #9151
_setOptionDisabled in $.Widget is now handling that. Ref #9151
Tabs support multiple values to disable individual tabs. Only add the ui-tabs-disabled class when all tabs are disabled. Ref #9151
|
Updated. Removed all the redundant calls in Updated tabs, renaming to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on top of jquerygh-1599, this fixes missing or redundant handling of the disabled option on create. The only missing widget is tabs. From my comment on the original PR: