Skip to content

Issue with oldest-supported-numpy package approach and pip 22.1 build validation with --no-build-isolation #53

Closed
@lesteve

Description

@lesteve
  • pip 22.1 (released recently on May 11) validates build requirements from pyproject.toml when using --no-build-isolation issue and PR
  • in scikit-learn we have oldest-supported-numpy in our pyproject.toml build requirements as advised in your README. I am guessing this is the case for a number of other projects (e.g. pandas does something similar)
  • Trying to do pip install --no-build-isolation . will error with a message like this:
    Some build dependencies for file:///home/local/lesteve/dev/scikit-learn are missing: 'oldest-supported-   numpy'.`
    
  • we also saw some issue in conda-forge with a similar error: Release 1.1.0 conda-forge/scikit-learn-feedstock#186 (comment) (I am guessing that conda-build is using --no-build-isolation)

Any suggestions on how to handle the situation nicely would be more than welcome! As a short-term fix, we have pinned pip to 22.0.4.

To reproduce with scikit-learn:

mamba create -n test cython scipy 'setuptools<60' -y
git clone https://github.com/scikit-learn/scikit-learn
cd scikit-learn
pip install --no-build-isolation .

Error

ERROR: Some build dependencies for file:///home/local/lesteve/dev/scikit-learn are missing: 'oldest-supported-numpy'.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions