Skip to content

[MRG] move from unittest to pytest #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 2, 2018

Conversation

wdevazelhes
Copy link
Member

@wdevazelhes wdevazelhes commented Apr 27, 2018

This PR replaces unittest by pytest. Pytest is more and more used and provides a flexible and advanced framework for testing. It is still compatible with unittests so the project testing would still work after this PR is merged. It would allow to code future tests for the new API in pytest.

@wdevazelhes wdevazelhes changed the title [MRG] use pytest rather than unittest [MRG] move from unittest to pytest Apr 27, 2018
Copy link
Contributor

@perimosocordiae perimosocordiae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for pytest.

The README.md instructions should be updated as well.

I wouldn't prioritize changing existing tests to use pytest-specific features, though.

@wdevazelhes
Copy link
Member Author

Yes I agree, it is not necessary to update existing tests (they might use pytest later but only if needed). I just updated the PR message.
Thanks for the README.txt, I'll update it.

Copy link
Member

@bellet bellet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, we can later rewrite some of the tests when we modify parts of the code

@perimosocordiae perimosocordiae merged commit c79875c into scikit-learn-contrib:master May 2, 2018
@wdevazelhes wdevazelhes deleted the pytest branch May 4, 2018 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants