Preventing a crash for LSML in a verbose mode #62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If LSML is created with
verbose=True
, the code crashes here https://github.com/searchivarius/metric-learn/blob/fac5ed5d4f0ae24d274e0956f4b7d2d6d09d2841/metric_learn/lsml.py#L95 due to uninitialized variables_best
. This is I believe a way to fix the problem.