adds code for safe return in case of no impostors for lmnn #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anirudt
changed the title
| @@ -203,6 +206,9 @@ def _find_impostors(self, furthest_neighbors): | |||
| tmp = np.ravel_multi_index((i,j), shape) | |||
| i,j = np.unravel_index(np.unique(tmp), shape) | |||
| impostors.append(np.vstack((in_inds[j], out_inds[i]))) | |||
| if len(impostors) == 0: | |||
| """No impostors detected""" | |||
| return [] | |||
There was a problem hiding this comment.
No need for a docstring here. Also, you can just return impostors instead of returning a new empty list.
|
Thanks! One small comment, but the change looks good overall. If something similar needs to be done for the other methods, we can handle those fixes separately. |
|
Sure, @perimosocordiae . Looking at the CI Build Details, the unrelated RCA test hasn't gone through. Does it need a look into it? |
|
The test failure is unrelated, though it did make me smile: Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix #17 .
I have done it for LMNN, is there a need for the others?