Skip to content

[MRG] Deprecate use_pca parameter of LMNN #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 4, 2019
Merged

[MRG] Deprecate use_pca parameter of LMNN #231

merged 2 commits into from
Jul 4, 2019

Conversation

bellet
Copy link
Member

@bellet bellet commented Jul 3, 2019

Fixes #222

@bellet
Copy link
Member Author

bellet commented Jul 3, 2019

If CI passes, we should be able to merge

@bellet bellet changed the title Deprecate use_pca parameter of LMNN [MRG] Deprecate use_pca parameter of LMNN Jul 3, 2019
@bellet bellet merged commit 731b327 into scikit-learn-contrib:master Jul 4, 2019
@bellet bellet deleted the deprecate_pca_lmnn branch August 14, 2019 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate use_pca for lmnn
1 participant
@bellet