[MRG] Remove shogun dependency #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdevazelhes
requested review from
bellet and
perimosocordiae
and removed request for
bellet
metric_learn/lmnn.py
Outdated
| @@ -25,7 +25,7 @@ | |||
|
|
|||
|
|
|||
| # commonality between LMNN implementations | |||
| class _base_LMNN(MahalanobisMixin, TransformerMixin): | |||
| class _BaseLMNN(MahalanobisMixin, TransformerMixin): | |||
There was a problem hiding this comment.
Seems like we can also get rid of this base class, right?
There was a problem hiding this comment.
Ah yes, that's right! I forgot about that, will do
added 2 commits
June 12, 2019 15:48
# Conflicts: # metric_learn/lmnn.py # test/test_base_metric.py
perimosocordiae
approved these changes
Jun 12, 2019
|
Test are green so I guess we can merge |
bellet
approved these changes
Jun 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #132
Fixes #192
This removes the shogun dependency