[MRG] Add checks for bounds argument #207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdevazelhes
commented
May 22, 2019
| @@ -192,7 +196,7 @@ def fit(self, pairs, y, bounds=None, calibration_params=None): | |||
| calibration_params = (calibration_params if calibration_params is not | |||
| None else dict()) | |||
| self._validate_calibration_params(**calibration_params) | |||
| self._fit(pairs, y) | |||
| self._fit(pairs, y, bounds=bounds) | |||
There was a problem hiding this comment.
This was missing before, but the new tests in this PR made it pop up that it's needed to transmit the bounds argument, otherwise no matter what it will be default (None)
perimosocordiae
approved these changes
May 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #161
This PR checks that when filling the
boundsargument in ITML, we use any array-like of two elementsAnd it adds to the doc that the subsequent
bounds_attribute will be anumpy.ndarrayQuestion: do we want to ensure that it's actually a 1D array ? For now I only check that is has size 2...