Skip to content

MMC - fit_diag can potentially loop forever #79

Closed
@shalan12

Description

@shalan12

For the condition in the while loop in MMC - fit_diag
while error > self.convergence_threshold:

I think the number of iterations should also be checked here. I've had runs where it keeps running and getting the same value for conv. It doesn't respect max_iter, and doesn't terminate.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions