Skip to content

Commit 6e00f61

Browse files
maxi-marufoMaximiliano Marufo da Silva
authored and
Maximiliano Marufo da Silva
committed
Updates test_warm_start
1 parent c3acfcf commit 6e00f61

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

test/metric_learn_test.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -337,9 +337,9 @@ def test_warm_start(self, basis):
337337
# We used the whole same dataset, so it can led to overfitting
338338
after = class_separation(scml.transform(X), y)
339339
if basis == "lda":
340-
assert before > after + 0.05 # For lda, it's better by a margin of 0.05
340+
assert before > after # For lda, class separation improved with re-fit
341341
else:
342-
assert before < after # For triplet_diffs, it overfits
342+
assert before < after # For triplet_diffs, it got worse
343343

344344
class TestLSML(MetricTestCase):
345345
def test_iris(self):

0 commit comments

Comments
 (0)