Skip to content

Commit c3acfcf

Browse files
maxi-marufoMaximiliano Marufo da Silva
authored and
Maximiliano Marufo da Silva
committed
Removes wrong assignment
1 parent e2fbfbe commit c3acfcf

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

metric_learn/scml.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,6 @@ def _fit(self, triplets, basis=None, n_basis=None):
8484
# l2 norm in time of all obj gradients wrt weights
8585
self.ada_grad_w_ = np.zeros((1, n_basis))
8686

87-
# l2 norm in time of all obj gradients wrt weights
88-
ada_grad_w = np.zeros((1, n_basis))
8987
# slack for not dividing by zero
9088
delta = 0.001
9189

@@ -104,7 +102,7 @@ def _fit(self, triplets, basis=None, n_basis=None):
104102
grad_w = np.sum(dist_diff[idx[slack_mask], :],
105103
axis=0, keepdims=True)/self.batch_size
106104

107-
self.avg_grad_w_ = (iter * self.avg_grad_w_ + grad_w) / (iter + 1)
105+
self.avg_grad_w_ = (iter * self.avg_grad_w_ + grad_w) / (iter+1)
108106

109107
self.ada_grad_w_ = np.sqrt(np.square(self.ada_grad_w_) + np.square(grad_w))
110108

0 commit comments

Comments
 (0)