Skip to content

[MRG] Update sklearn minimum version #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2021
Merged

[MRG] Update sklearn minimum version #840

merged 1 commit into from
May 25, 2021

Conversation

fferegrino
Copy link
Contributor

Reference Issue

Fixes #839

What does this implement/fix? Explain your changes.

The minimum version for scikit-learn was outdated; the change was introduced in this commit f40e654 but the README.rst was never updated.

Any other comments?

@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #840 (3bb2771) into master (3748569) will decrease coverage by 0.42%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #840      +/-   ##
==========================================
- Coverage   98.69%   98.26%   -0.43%     
==========================================
  Files          93       93              
  Lines        6063     6063              
  Branches      508      508              
==========================================
- Hits         5984     5958      -26     
- Misses         78      104      +26     
  Partials        1        1              
Impacted Files Coverage Δ
imblearn/datasets/tests/test_zenodo.py 56.75% <0.00%> (-32.44%) ⬇️
imblearn/datasets/_zenodo.py 74.19% <0.00%> (-22.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3748569...3bb2771. Read the comment docs.

Copy link
Member

@hayesall hayesall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The codecov error looks unrelated, might have been a temporary network error on one of the CI jobs when accessing zenodo.

Looks good to me!

@hayesall hayesall merged commit edf6eae into scikit-learn-contrib:master May 25, 2021
@fferegrino fferegrino deleted the fferegrino-fix-sklearn-version-readme branch May 25, 2021 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Fix scikit-learn minimum version
2 participants