Skip to content

MAINT Update CI #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 31, 2020
Merged

MAINT Update CI #679

merged 4 commits into from
Jan 31, 2020

Conversation

chkoar
Copy link
Member

@chkoar chkoar commented Jan 31, 2020

  • Remove pandas from ubuntu based py35 builds
  • Update a failed test of InstanceHardnessThreshold that uses GradientBoostingClassifier. Changes have been made in scikit-learn so the classifier was returning different results. I used Naive Bayes instead.
  • Update doctest for RUSBoostClassifier due to changes in trees in scikit-learn
  • Remove Appveyor

@codecov
Copy link

codecov bot commented Jan 31, 2020

Codecov Report

Merging #679 into master will decrease coverage by 2.18%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #679      +/-   ##
=========================================
- Coverage   98.59%   96.4%   -2.19%     
=========================================
  Files          82      82              
  Lines        4841    4842       +1     
=========================================
- Hits         4773    4668     -105     
- Misses         68     174     +106
Impacted Files Coverage Δ
...election/tests/test_instance_hardness_threshold.py 100% <100%> (ø) ⬆️
imblearn/keras/tests/test_generator.py 8.62% <0%> (-91.38%) ⬇️
imblearn/tensorflow/_generator.py 30% <0%> (-70%) ⬇️
imblearn/keras/_generator.py 50.74% <0%> (-47.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b86e72...94dcf35. Read the comment docs.

@chkoar chkoar changed the title Remove pandas from Ubuntu based py35 builds Fix CI Jan 31, 2020
@chkoar chkoar changed the title Fix CI MAIT Fix CI Jan 31, 2020
@chkoar chkoar changed the title MAIT Fix CI MAINT Update CI Jan 31, 2020
@chkoar chkoar requested a review from glemaitre January 31, 2020 16:09
@glemaitre
Copy link
Member

LGTM

@glemaitre glemaitre merged commit b9a290a into scikit-learn-contrib:master Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants