Skip to content

[MRG] ENH: RepeatedENN n_iter_ Attribute #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 20, 2019

Conversation

MattEding
Copy link
Contributor

What does this implement/fix? Explain your changes.

To mimic Scikit-Learn API of estimators that have a max_iter parameter, I have added n_iter_ as an attribute after fitting. See KMeans for such an example.

Any other comments?

Fixed typo with my name in What's New v0.6

@glemaitre
Copy link
Member

Thanks. Could you add a test to check that max_iter is consistent with n_iter_. It allows us to check that we have the attribute. The failure is unrelated (it should be some temporary failure from the OpenML server).

@codecov
Copy link

codecov bot commented Nov 20, 2019

Codecov Report

Merging #651 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #651      +/-   ##
==========================================
+ Coverage   98.46%   98.46%   +<.01%     
==========================================
  Files          82       82              
  Lines        4873     4881       +8     
==========================================
+ Hits         4798     4806       +8     
  Misses         75       75
Impacted Files Coverage Δ
..._prototype_selection/_edited_nearest_neighbours.py 100% <100%> (ø) ⬆️
...n/tests/test_repeated_edited_nearest_neighbours.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a1191e...da71b3a. Read the comment docs.

Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glemaitre glemaitre merged commit 06fe9ba into scikit-learn-contrib:master Nov 20, 2019
@MattEding MattEding deleted the n_iter_ branch November 21, 2019 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants