Skip to content

[MRG] Add development doc #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2017

Conversation

massich
Copy link
Contributor

@massich massich commented Aug 22, 2017

@glemaitre which functions should be documented here?

@glemaitre
Copy link
Member

all public functions in validation.py and deprecation.py

There is currently nothing in testing.py to be documented.

@codecov
Copy link

codecov bot commented Aug 22, 2017

Codecov Report

Merging #325 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #325   +/-   ##
=====================================
  Coverage      98%    98%           
=====================================
  Files          66     66           
  Lines        3860   3860           
=====================================
  Hits         3783   3783           
  Misses         77     77

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f02c565...a3db4a4. Read the comment docs.

@massich massich force-pushed the development_doc branch 2 times, most recently from c615d02 to ff2c024 Compare August 22, 2017 15:06
@massich massich changed the title [WIP] Add development doc [MRG] Add development doc Aug 22, 2017

.. currentmodule:: imblearn.utils


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove one line

scikit-learn. Backports, in particular, will be removed as the scikit-learn
dependencies evolve.


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove one line

Utilities for Developers
========================

Imbalanced-learn contains a number of utilities to help with development. These are
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a space to much between . and These

.. warning ::

These utilities are meant to be used internally within the imbalanced-learn
package. They are not guaranteed to be stable between versions of
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space to much after full stop


These utilities are meant to be used internally within the imbalanced-learn
package. They are not guaranteed to be stable between versions of
scikit-learn. Backports, in particular, will be removed as the scikit-learn
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scikit-learn -> imbalanced-learn

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the end of the sentence as well

Validation Tools
================

These are tools used to check and validate input. When you write a function
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space to much after full stop


Helper Functions
================
These are tools to facilitate writing code for imbalance learn.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imbalance learn -> imbalanced-learn

@glemaitre glemaitre merged commit a864553 into scikit-learn-contrib:master Aug 22, 2017
@massich massich deleted the development_doc branch August 22, 2017 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants