Skip to content

[MRG] EHN allow to become minority in AllKNN #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2017

Conversation

glemaitre
Copy link
Member

Sometime it could be useful to be a bit more tolerant

@glemaitre
Copy link
Member Author

@massich @chkoar

@codecov
Copy link

codecov bot commented Aug 7, 2017

Codecov Report

Merging #313 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #313      +/-   ##
==========================================
+ Coverage   98.32%   98.32%   +<.01%     
==========================================
  Files          68       68              
  Lines        3879     3890      +11     
==========================================
+ Hits         3814     3825      +11     
  Misses         65       65
Impacted Files Coverage Δ
..._sampling/prototype_selection/tests/test_allknn.py 100% <100%> (ø) ⬆️
...g/prototype_selection/edited_nearest_neighbours.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c0628f...158e16e. Read the comment docs.

@massich
Copy link
Contributor

massich commented Aug 8, 2017

LGTM, I'll have to rebase.

@chkoar
Copy link
Member

chkoar commented Aug 8, 2017

Sometime it could be useful to be a bit more tolerant

Is this a research finding or personal experience? Either way is okay.

@glemaitre
Copy link
Member Author

It is something that I introduced. But reading the original paper one could force to under-sample as much as possible if he is willing too.

@glemaitre glemaitre merged commit 50dd208 into scikit-learn-contrib:master Aug 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants