Skip to content

'm_neighbors' vs 'k_neighbors'  #568

Closed
@laurallu

Description

@laurallu

Description

Question about the codes in BorderlineSMOTE and SVMSMOTE: In the function validate_estimator(), self.nn_m = check_neighbors_object(
'k_neighbors', self.k_neighbors, additional_neighbor=1).

It seems to me that 'm_neighbors' instead of 'k_neighbors' should be used since in this step we are setting the number of neighbors used to determine the minority samples in danger.
See lines 326 and 509 in the source code of SMOTE.

Steps/Code to Reproduce

Expected Results

Actual Results

Versions

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions