Skip to content

BytesLocation: Add method to set the name for the Location #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 31, 2019

Conversation

gab1one
Copy link
Contributor

@gab1one gab1one commented Jan 23, 2019

In some instances libarary users want to create a BytesLocation that has
a specific name, e.g. so that it is correctly detected by a Service that
performs a name based lookup.

This came up as a requirement several times during the fiji hackathon at it4inovations

@gab1one gab1one requested a review from ctrueden January 23, 2019 14:37
@gab1one gab1one force-pushed the add-name-to-bytes-location branch from 5589d57 to f818777 Compare January 23, 2019 14:45
In some instances libarary users want to create a BytesLocation that has
a specific name, e.g. so that it is correctly detected by a Service that
performs a name based lookup.
@gab1one gab1one force-pushed the add-name-to-bytes-location branch from f818777 to 80f96e7 Compare January 24, 2019 12:27
@ctrueden ctrueden merged commit f329e5b into master Jan 31, 2019
@ctrueden ctrueden deleted the add-name-to-bytes-location branch January 31, 2019 23:15
@ctrueden
Copy link
Member

Thanks @gab1one.

I see that getName() already existed in the Location API, so I'm OK with adding the constructors etc. to BytesLocation. I do have some concerns about using the name for technical things like differentiation of content types, as we discussed via voice the other day. Might be good to discuss further on image.sc or on a GitHub issue here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants