ReadBufferDataHandle: ensure pages are fully read #346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reading bytes with `DataHandle#read(bytes[], off, len)` results in *up to* `len` bytes being read into the provided array. In ReadBufferHandleDataHandle the number of read bytes was not checked, this lead to partially filled pages resulting in read errors. Now the reading is repeated until the page is either full or EOF is reached. And adapt to changes in ReadBufferDataHandle.
ctrueden
force-pushed
the
fix-read-buffer-data-handle
branch
from
03c2171 to
4a20b44
Compare
|
Thank you for fixing this! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading bytes with
DataHandle#read(bytes[], off, len)results in upto
lenbytes being read into the provided array.In ReadBufferHandleDataHandle the number of read bytes was not checked,
this lead to partially filled pages resulting in read errors. Now the
reading is repeated until the page is either full or EOF is reached.