Script values #163
Merged
Script values #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ModuleItem#getDefaultValue() method returns the intended default value for the item, or null if none such. And the MutableModuleItem#setDefaultValue(T) method lets it be set. Of course, as of this commit, nothing respects the setting yet.
When calling ModuleService#getDefaultValue(ModuleItem), if the ModuleItem in question has an explict default value -- as obtained from the new ModuleItem#getDefaultValue() accessor -- then that value should take precedence over any other possibility.
ctrueden
force-pushed
the
script-values
branch
2 times, most recently
from
e0e4663 to
d3f0040
Compare
Unresolved module items should be assigned their default value, as given by the ModuleService#getDefaultValue() method, before anything else (even module initialization!) happens.
You can now write: @int(value = 5) sigma And the sigma variable will have a default value of 5 the first time the script is run. Nicer would be: @int sigma = 5 But implementing that would be more involved, and so should probably wait till script parameter parsing is truly fixed as described in #156.
|
@hinerm Just looking for quick code review, then feel free to merge! In conjuction with scijava/scijava-ui-swing#11, this fixes default value handling as discussed recently on the mailing list. |
hinerm
added a commit
that referenced
this pull request
May 1, 2015
Add default value support for module items and script parameters
|
Awesome @ctrueden ! 🐙 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch makes default values work better:
ModuleItema default value property which can be retrieved and (in the case ofMutableModuleItem) set.DefaultValuePreprocessor. This eliminates the inconsistency between default value handling of primitives and theirjava.langwrapper types.valueattribute to script parameter parsing, so that you can write e.g.@int(value=5) sigmato set a default value for script parameters. (Ideally, we'd support@int sigma = 5too, but for the moment that would be more work, so we can punt for now.)