feat: add support for self hosted gateway #62
Conversation
| ) | ||
|
|
||
| import time | ||
|
|
||
| # TODO?: delete this. It's a kubernetes side-effect. | ||
| time.sleep(30) |
There was a problem hiding this comment.
This test is flaky, unfortunately :( Sometimes the updated function is marked as ready but it's older version will still respond to requests for up to a ~~minute.
There was a problem hiding this comment.
It's very random though which is why the CI passed when we merged those tests in #55.
There was a problem hiding this comment.
Can we do the same trick of retrying every 5 seconds for 50 seconds and only passing if it's the updated function response?
|
|
||
| time.sleep(60) | ||
| # TODO?: delete this | ||
| time.sleep(30) |
There was a problem hiding this comment.
With sleeps like this it's cleaner to add a loop that retries up to some limit. Perhaps we can add a utility function to trigger a function, then sleep for 5 seconds and retry, up to 10 retries?
| ) | ||
|
|
||
| import time | ||
|
|
||
| # TODO?: delete this. It's a kubernetes side-effect. | ||
| time.sleep(30) |
There was a problem hiding this comment.
Can we do the same trick of retrying every 5 seconds for 50 seconds and only passing if it's the updated function response?
| return key | ||
|
|
||
|
|
||
| def _deploy_gateway(project_id: str, client: Client) -> sdk.Container: |
There was a problem hiding this comment.
I am worried about duplicating the gateway logic in this test. Instead, it might be cleaner and safer to have a setup step in the integration tests which did the following:
- Check out a tag of the API gateway
- Run the relevant
makecommands to set up the gateway - Run a (new?)
makecommand to get any valid auth key - Run another (new?)
makecommand to get the gateway URL - Export this auth key and gateway URLs as environment variables to be used in this test
As I've noted, I'm not sure if the make interface in the gateway supports this, but it would be nice if it did. If it works, this could then become a reusable Github Action to set up and use your own gateway.
cyclimse
force-pushed
the
feat/add-support-for-self-hosted-gateway
branch
from
a07a3aa to
3d935ea
Compare
Co-authored-by: Simon Shillaker <554768+Shillaker@users.noreply.github.com>
Summary
What's changed?
The API framework can now manage routes for the self-hosted gateway project.
Why do we need this?
To provide the functionality to
@app.get(...)decorators.How have you tested it?
There are unit tests that mock the gateway with responses.
As well as an integration test.
Checklist
Details
Currently, the integration test will fail because of tiny issues with the gateway. I've opened some PRs to address them.