feat: update to new serverless gateway #111
Conversation
cyclimse
force-pushed
the
feat/update-gateway-to-vanilla-kong
branch
3 times, most recently
from
2e87677 to
14b8661
Compare
cyclimse
force-pushed
the
feat/update-gateway-to-vanilla-kong
branch
from
12e1c60 to
2cc1014
Compare
| ) | ||
| raise RuntimeError("scwgw is not installed") | ||
|
|
||
| self.cli = cli |
There was a problem hiding this comment.
Initially, I wanted to run scwgw check here to fail fast if the gateway container were not ready, but the problem was that env vars are not properly passed to the subprocess (intended behavior to avoid security issues) and that output parsing was a bit ugly.
What do you think?
There was a problem hiding this comment.
I think it's ok to assume the gateway has to be fully set up and working before using this framework. Having checks running in here is mixing responsibilities, so I'm happy not to include it.
| from scw_serverless.config.route import GatewayRoute | ||
|
|
||
|
|
||
| class Gateway(Protocol): |
There was a problem hiding this comment.
Might be a bit anti YAGMI to use a protocol when we have a single implementation, it's only useful for the unit tess.
| @@ -33,12 +33,3 @@ def validate(self) -> None: | |||
| for method in self.http_methods or []: | |||
| if method not in HTTPMethod: | |||
| raise RuntimeError(f"Route contains invalid method {method.value}") | |||
|
|
|||
| def asdict(self) -> dict[str, Any]: | |||
There was a problem hiding this comment.
This only is highly dependent of the gateway, so I prefer to have it in the gateway part of the code. It's what we do the other config options.
| ) | ||
| raise RuntimeError("scwgw is not installed") | ||
|
|
||
| self.cli = cli |
There was a problem hiding this comment.
I think it's ok to assume the gateway has to be fully set up and working before using this framework. Having checks running in here is mixing responsibilities, so I'm happy not to include it.
Summary
What's changed?
Why do we need this?
How have you tested it?
Checklist
Details
scwgwCLI in subprocesses.