Add API V2 support #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartdietrich
force-pushed
the
taskapi-v2
branch
from
413a757 to
cbdcba5
Compare
| @@ -17,11 +17,11 @@ jobs: | |||
| - run: | |||
| name: Black Formatting Check # Only validation, without re-formatting | |||
| command: | | |||
| black --check -t py36 . | |||
| black --check --exclude 'scaleapi/api_client/*' -t py38 . | |||
There was a problem hiding this comment.
is there a way to run it through black after we generate. We run the typescript one through prettier
There was a problem hiding this comment.
not a big deal if it's not easy
There was a problem hiding this comment.
yeah there's also some others in the precommit, can try to do something similar next time
| @@ -318,6 +330,83 @@ def tasks(self, **kwargs) -> Tasklist: | |||
| response.get("next_token"), | |||
| ) | |||
|
|
|||
| def v2_get_tasks( | |||
There was a problem hiding this comment.
so you can do like:
client = ScaleClient()
client.v2_get_tasks(...)
client.v2.get_tasks(...)
right?
There was a problem hiding this comment.
yes, where v2. exposes the auto-generated and v2_get_tasks is to match existing get_tasks pagination
michaelbishoff
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Description
Please include a summary of the changes. Please also include the relevant context and motivation. List any dependencies and assumptions that are required for this change.
Added client for V2 endpoints and utility function
v2_get_tasks. Updated requirements and python version to >=3.8 to support the new client.How did you test your code?
Which of the following have you done to test your changes? Please describe the tests that you ran to verify your changes.
tests/for the newly implemented methodstests/to cover changes made to existing methodsAdded tests for
v2_get_tasksandv2.get_task- leaving commented until they can pass for other users.Checklist
Please make sure all items in this checklist have been fulfilled before sending your PR out for review!
_version.py(unless this PR only updates the documentation).