Skip to content

Handle empty retries #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Handle empty retries #89

merged 2 commits into from
Jun 5, 2024

Conversation

fatihkurtoglu
Copy link
Contributor

@fatihkurtoglu fatihkurtoglu commented Jun 5, 2024

Pull Request Summary

Description

  • With this change, empty or non-existent raw, retries and history attributes of a Response object is handled more elegantly.

How did you test your code?

Which of the following have you done to test your changes? Please describe the tests that you ran to verify your changes.

  • Created new unit tests in tests/ for the newly implemented methods
  • Updated existing unit tests in tests/ to cover changes made to existing methods

Checklist

Please make sure all items in this checklist have been fulfilled before sending your PR out for review!

  • I have commented my code in details, particularly in hard-to-understand areas
  • I have updated Readme.rst document with examples for newly implemented public methods
  • I have reviewed Deployment and Publishing Guide for Python SDK document
  • I incremented the SDK version in _version.py (unless this PR only updates the documentation).
  • In order to release a new version, a "Release Summary" needs to be prepared and published after the merge

@jonathanfeng-scale jonathanfeng-scale merged commit 396f864 into master Jun 5, 2024
3 checks passed
@fatihkurtoglu fatihkurtoglu deleted the handle-empty-retries branch June 5, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants