Skip to content

Add ChatExperimental TaskType #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 21, 2024
Merged

Add ChatExperimental TaskType #85

merged 5 commits into from
May 21, 2024

Conversation

nkasturi1
Copy link

@nkasturi1 nkasturi1 commented May 21, 2024

Pull Request Summary

Description

Add support for the ChatExperimental task type. I am also adding the endpoint in the main repo.

How did you test your code?

Which of the following have you done to test your changes? Please describe the tests that you ran to verify your changes.

  • Created new unit tests in tests/ for the newly implemented methods
  • Updated existing unit tests in tests/ to cover changes made to existing methods

Checklist

Please make sure all items in this checklist have been fulfilled before sending your PR out for review!

  • I have commented my code in details, particularly in hard-to-understand areas
  • I have updated Readme.rst document with examples for newly implemented public methods
  • I have reviewed Deployment and Publishing Guide for Python SDK document
  • I incremented the SDK version in _version.py (unless this PR only updates the documentation).
  • In order to release a new version, a "Release Summary" needs to be prepared and published after the merge

@jonathanfeng-scale
Copy link
Contributor

Can we comment out the test_teammates tests? I think they're failing :( and will likely prevent deployment / merging

@fatihkurtoglu
Copy link
Contributor

@nkasturi1 could you also bump the version, as per the guidelines here?
https://github.com/scaleapi/scaleapi-python-client/blob/master/docs/pypi_update_guide.md

@nkasturi1 nkasturi1 merged commit d6cb2be into master May 21, 2024
3 checks passed
@nkasturi1 nkasturi1 deleted the chat-experimental branch May 21, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants