Skip to content

adding proxy support to SDK #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2023
Merged

adding proxy support to SDK #72

merged 2 commits into from
May 13, 2023

Conversation

fatihkurtoglu
Copy link
Contributor

Pull Request Summary

  • Adding proxy support to SDK Client initialization. Now users can pass proxies, cert and verify parameters to their requests
    proxies = { 'https': 'http://10.10.1.10:1080' }
    
    client = scaleapi.ScaleClient(
                api_key="YOUR_API_KEY_HERE",
                proxies=proxies,
                cert='/path/client.cert',
                verify=True
            )

Description

Please include a summary of the changes. Please also include the relevant context and motivation. List any dependencies and assumptions that are required for this change.

How did you test your code?

Which of the following have you done to test your changes? Please describe the tests that you ran to verify your changes.

  • Created new unit tests in tests/ for the newly implemented methods
  • Updated existing unit tests in tests/ to cover changes made to existing methods

Checklist

Please make sure all items in this checklist have been fulfilled before sending your PR out for review!

  • I have commented my code in details, particularly in hard-to-understand areas
  • I have updated Readme.rst document with examples for newly implemented public methods
  • I have reviewed Deployment and Publishing Guide for Python SDK document
  • I incremented the SDK version in _version.py (unless this PR only updates the documentation).
  • In order to release a new version, a "Release Summary" needs to be prepared and published after the merge

Copy link
Contributor

@jonathanfeng-scale jonathanfeng-scale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shaun-scale shaun-scale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems straightforward, thank you for implementing + documenting!

@fatihkurtoglu fatihkurtoglu merged commit 9e04b5e into master May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants