Skip to content

allow datasetId on project creation #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 10, 2023

Conversation

jean-lucas
Copy link
Contributor

@jean-lucas jean-lucas commented Apr 25, 2023

Pull Request Summary

Description

  • Allows project creation to be linked to an existing dataset

[sc-747086]

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #747086: On project creation, link to dataset.

@jean-lucas jean-lucas requested a review from gatli April 27, 2023 14:22
@jean-lucas jean-lucas marked this pull request as ready for review April 27, 2023 14:22
Copy link

@gatli gatli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

i.e. `{'instruction':'Please label the kittens'}`
rapid (bool):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two boolean variables that are only valid when xor'd. Great 🙈

Kudos on the doc string though!

@gatli
Copy link

gatli commented May 3, 2023

@jean-lucas I don't have write access so it didn't fulfill checks. I'm asking for it now 🤸‍♂️

@jean-lucas
Copy link
Contributor Author

@jean-lucas I don't have write access so it didn't fulfill checks. I'm asking for it now 🤸‍♂️

All good 👍 I got an automatic grant from Opal when I requested write access to this repo

@jean-lucas jean-lucas merged commit f2d0a83 into master May 10, 2023
@jean-lucas jean-lucas deleted the jean-lucas-pass-dataset-on-project branch May 10, 2023 10:59
@jean-lucas jean-lucas restored the jean-lucas-pass-dataset-on-project branch May 10, 2023 11:01
@jean-lucas jean-lucas deleted the jean-lucas-pass-dataset-on-project branch May 10, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants