Skip to content

Add task audit endpoints to SDK #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 13, 2022
Merged

Add task audit endpoints to SDK #64

merged 2 commits into from
Dec 13, 2022

Conversation

fatihkurtoglu
Copy link
Contributor

Pull Request Summary

  • Implementing existing task accept/reject API for audits to SDK
  • client.audit_task() as well as task.audit() are implemented methods
  • Readme is updated with examples

TODO: Testing of audit endpoint via test task/project is not available so that part is to-be implemented later.

Description

Implementing already existing audit API endpoint into the SDK.
https://docs.scale.com/reference/audit-a-task

How did you test your code?

Which of the following have you done to test your changes? Please describe the tests that you ran to verify your changes.

  • Created new unit tests in tests/ for the newly implemented methods
  • Updated existing unit tests in tests/ to cover changes made to existing methods

Checklist

Please make sure all items in this checklist have been fulfilled before sending your PR out for review!

  • I have commented my code in details, particularly in hard-to-understand areas
  • I have updated Readme.rst document with examples for newly implemented public methods
  • I have reviewed Deployment and Publishing Guide for Python SDK document
  • I incremented the SDK version in _version.py (unless this PR only updates the documentation).
  • In order to release a new version, a "Release Summary" needs to be prepared and published after the merge

@fatihkurtoglu
Copy link
Contributor Author

@jonathanfeng-scale FYI, Used the same next version with your PR #63 so we can update according to whoever merges earlier.

Copy link
Contributor

@jonathanfeng-scale jonathanfeng-scale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This can the the v2.11

Studio can be v2.12

@fatihkurtoglu fatihkurtoglu merged commit 55c52c2 into master Dec 13, 2022
@fatihkurtoglu fatihkurtoglu deleted the task-audit-api branch December 13, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants