Skip to content

Remove json from HTTP requests for ScaleGov #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 2, 2022
Merged

Conversation

edwardpark97
Copy link
Contributor

Our ScaleGov environment has an AWS WAF (Web Application Firewall) that errors out on any GET request that has a json parameter (for some reason or another)

Tested with the ScaleGov API, also tested with the Commercial API with pytest test_client.py and it seemed to be fine

@fatihkurtoglu
Copy link
Contributor

@edwardpark97 Thanks for the PR. Could you also bump the minor version?

__version__ = "2.5.0"

Copy link
Contributor

@fatihkurtoglu fatihkurtoglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@edwardpark97
Copy link
Contributor Author

@fatihkurtoglu @shaun-scale How do I go about pushing this change to PyPi? Is it automatically done or is there some manual step needed?

@edwardpark97 edwardpark97 merged commit 5e4d0fe into master Feb 2, 2022
@edwardpark97 edwardpark97 deleted the support_scalegov branch February 2, 2022 17:11
@fatihkurtoglu
Copy link
Contributor

@fatihkurtoglu @shaun-scale How do I go about pushing this change to PyPi? Is it automatically done or is there some manual step needed?

Sorry missed that comment earlier. Process for pushing package to PyPi is explained here:
https://github.com/scaleapi/scaleapi-python-client/blob/master/docs/pypi_update_guide.md

In order to deploy and publish a new version:
Create a new Release on GitHub
Create and assign a new tag in the release page with the following template: vX.Y.Z Please make sure X.Y.Z is matching the version in the _version.py.
i.e. If the version in _version.py is 2.3.1 then the tag should be v2.3.1
Provide release notes by following the Release Notes Template and filling relevant sections to your changes.

@edwardpark97
Copy link
Contributor Author

Yup just did it! Not totally sure if it successfully triggered or not but I guess I'll find out soon enough

@fatihkurtoglu
Copy link
Contributor

https://app.circleci.com/pipelines/github/scaleapi/scaleapi-python-client
pypi_publish workflow seems to be run successfully!

@fatihkurtoglu
Copy link
Contributor

FYI: There seems to be an issue in conda deployment: conda-forge/scaleapi-feedstock#10
Found an existing issue on conda-forge and will follow up with them conda-forge/conda-forge.github.io#1604

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants