Skip to content

Enable client to operate against different API instances #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 30, 2021

Conversation

glasperfan
Copy link
Contributor

The Python client only works with Scale's public API. This enables it to be used with separate API instances.

sc = ScaleClient(MY_API_KEY, api_instance_url="https://separate.api.env.scale.com/v1")

@shaun-scale
Copy link
Contributor

Thanks @glasperfan ! We had this on our roadmap to build this week and had been waiting on some outstanding questions about the use-case you built this for to be answered but you beat us to it - This works for me 😅 Thank you 🙏

@fatihkurtoglu is this pretty much what you had in mind? I think it's what I had in mind.

Copy link
Contributor

@fatihkurtoglu fatihkurtoglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @glasperfan for your contribution to the SDK!

@fatihkurtoglu fatihkurtoglu merged commit 8e248f2 into scaleapi:master Jun 30, 2021
@glasperfan
Copy link
Contributor Author

Thanks @fatihkurtoglu. Do we need to bump the version in conda-forge to get the latest release there?

@shaun-scale
Copy link
Contributor

@glasperfan yeah, we'll need to merge in conda-forge/scaleapi-feedstock#1 (the PR on Conda is automatically created based on this repo) - should be done today!

@fatihkurtoglu
Copy link
Contributor

fatihkurtoglu commented Jul 1, 2021

@glasperfan conda-forge is updated with the version 2.2.0! You can find release notes here.

@glasperfan
Copy link
Contributor Author

Thanks both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants