Skip to content

Dev 2.0.5 #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 4, 2021
Merged

Dev 2.0.5 #36

merged 4 commits into from
May 4, 2021

Conversation

fatihkurtoglu
Copy link
Contributor

  • Readme updates
  • Extended list of retry codes with 408 and Cloudflare 5xx codes

@fatihkurtoglu fatihkurtoglu requested a review from shaun-scale May 4, 2021 01:02
shaun-scale
shaun-scale approved these changes May 4, 2021
View reviewed changes
Copy link
Contributor

@shaun-scale shaun-scale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me, thanks!

scaleapi/api.py
524,
525,
] # Status codes to force retry
HTTP_STATUS_FORCE_LIST = [408, 429] + list(range(500, 531))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the range ;)

@fatihkurtoglu fatihkurtoglu marked this pull request as ready for review May 4, 2021 02:04
@fatihkurtoglu fatihkurtoglu merged commit 8094e65 into master May 4, 2021
@fatihkurtoglu fatihkurtoglu deleted the dev-2.0.5 branch May 4, 2021 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaun-scale shaun-scale shaun-scale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fatihkurtoglu @shaun-scale