Skip to content

Refactor a lot of segmentation local upload and async logic #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Mar 16, 2022
Merged

Refactor a lot of segmentation local upload and async logic #256

merged 11 commits into from
Mar 16, 2022

Conversation

ardila
Copy link
Contributor

@ardila ardila commented Mar 11, 2022 •
edited
Loading

  • Refactor async related code to its own module so it is easier to reuse
  • Refactor out annotation upload logic since we are making it even more complex. Move it to its own module as well.
  • Fix issues with retries/clarify typing throughout async code
  • Add local upload for masks.
  • Delete some unused/irrelevant methods in base client.

@ardila ardila changed the title Cleanup Asycn Form Data requests + Segmentation local upload Refactor a lot of segmentation local upload and async logic Mar 11, 2022
gatli
gatli approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@gatli gatli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 🔥

@ardila ardila force-pushed the da-local-segmentation branch from 530e64a to 5b501d1 Compare March 15, 2022 17:36
@ardila ardila merged commit 9040e04 into master Mar 16, 2022
@ardila ardila deleted the da-local-segmentation branch March 16, 2022 18:20
gatli pushed a commit that referenced this pull request Mar 30, 2022
@ardila @gatli
Refactor a lot of segmentation local upload and async logic (#256)
203d0f2 
* work in progress

* work in progress

* Big refactor to make things cleaner + enable retries properly on infra flakes for local upload

* work in progress refactor of annotation upload

* Fixed segmentation bugs

* Fix one more bug and remove use of annotate_segmentation endpoint

* refactor tests and add segmentation local upload test

* Tests passing

* Review feedback

* Initial pass at client changes for prediction segmentation upload

* relevant tests pass

Co-authored-by: Ubuntu <diego.ardila@scale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gatli gatli gatli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ardila @gatli