Remove default logging in the Data Loader DAO #2708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request removes default logging for DAO operations to prevent excessive console output during data imports. The changes include:
- Removal of logger imports and logger instance
- Deletion of log messages after GET and PUT operations in storage and transaction modes
- Removal of log messages from SCAN operations
thongdk8
changed the title
komamitsu
reviewed
May 29, 2025
| @@ -59,9 +50,7 @@ public Optional<Result> get( | |||
|
|
|||
| try { | |||
| Get get = createGetWith(namespace, table, partitionKey, clusteringKey); | |||
| Optional<Result> result = storage.get(get); | |||
| logger.info(String.format(GET_COMPLETED_MSG, loggingKey)); | |||
There was a problem hiding this comment.
I think there is another option to change the log level to DEBUG or TRACE. What do you think?
There was a problem hiding this comment.
We will add some verbose options later in the command args, also with some progress printing to the console I think. So we're gonna add the logger back if needed. WDYT? cc @ypeckstadt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the data loader logs every operation related to DAO operations by default, which is not user-friendly, especially when importing data every get, put is printed to the console. So we should remove this default behavior and add a proper verbose option later in another PR. PTAL. Thank you.
Related issues and/or PRs
NA
Changes made
Checklist
Additional notes (optional)
NA
Release notes
NA