Skip to content

Fix package and package object categories #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/typescript/Scala.tmLanguage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -840,7 +840,7 @@ export const scalaTmLanguage: TmLanguage = {
match: `\\b(package)\\s+(object)\\b\\s*${notStartOfComment}(${anyId})?`,
captures: {
'1': {
name: 'keyword.other.scoping.scala'
name: 'keyword.other.package.scala'
},
'2': {
name: 'keyword.declaration.scala'
Expand All @@ -855,7 +855,7 @@ export const scalaTmLanguage: TmLanguage = {
begin: '\\b(package)\\s+',
beginCaptures: {
'1': {
name: 'keyword.other.import.scala'
name: 'keyword.other.package.scala'
}
},
patterns: [
Expand Down
2 changes: 1 addition & 1 deletion tests/snap/comments.test.scala.snap
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@
#^ source.scala comment.block.documentation.scala
# ^^ source.scala comment.block.documentation.scala punctuation.definition.comment.scala
>package complex {}
#^^^^^^^ source.scala meta.package.scala keyword.other.import.scala
#^^^^^^^ source.scala meta.package.scala keyword.other.package.scala
# ^ source.scala meta.package.scala
# ^^^^^^^ source.scala meta.package.scala entity.name.package.scala
# ^^^^ source.scala meta.package.scala
Expand Down
2 changes: 1 addition & 1 deletion tests/snap/end.test.scala.snap
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
# ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ source.scala comment.line.double-slash.scala
>
>package p1.p2:
#^^^^^^^ source.scala meta.package.scala keyword.other.import.scala
#^^^^^^^ source.scala meta.package.scala keyword.other.package.scala
# ^ source.scala meta.package.scala
# ^^ source.scala meta.package.scala entity.name.package.scala
# ^ source.scala meta.package.scala punctuation.definition.package
Expand Down
12 changes: 6 additions & 6 deletions tests/snap/scala_spec.test.scala.snap
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
>package org.scala.syntax
#^^^^^^^ source.scala meta.package.scala keyword.other.import.scala
#^^^^^^^ source.scala meta.package.scala keyword.other.package.scala
# ^ source.scala meta.package.scala
# ^^^ source.scala meta.package.scala entity.name.package.scala
# ^ source.scala meta.package.scala punctuation.definition.package
# ^^^^^ source.scala meta.package.scala entity.name.package.scala
# ^ source.scala meta.package.scala punctuation.definition.package
# ^^^^^^ source.scala meta.package.scala entity.name.package.scala
>package test
#^^^^^^^ source.scala meta.package.scala keyword.other.import.scala
#^^^^^^^ source.scala meta.package.scala keyword.other.package.scala
# ^ source.scala meta.package.scala
# ^^^^ source.scala meta.package.scala entity.name.package.scala
>
Expand Down Expand Up @@ -333,7 +333,7 @@
#^ source.scala punctuation.section.block.end.scala
>
>package org.scala {
#^^^^^^^ source.scala meta.package.scala keyword.other.import.scala
#^^^^^^^ source.scala meta.package.scala keyword.other.package.scala
# ^ source.scala meta.package.scala
# ^^^ source.scala meta.package.scala entity.name.package.scala
# ^ source.scala meta.package.scala punctuation.definition.package
Expand Down Expand Up @@ -2284,13 +2284,13 @@
#^ source.scala punctuation.section.block.end.scala
>
>package p1 {
#^^^^^^^ source.scala meta.package.scala keyword.other.import.scala
#^^^^^^^ source.scala meta.package.scala keyword.other.package.scala
# ^ source.scala meta.package.scala
# ^^ source.scala meta.package.scala entity.name.package.scala
# ^^^ source.scala meta.package.scala
> package p2 {
#^^^^ source.scala
# ^^^^^^^ source.scala meta.package.scala keyword.other.import.scala
# ^^^^^^^ source.scala meta.package.scala keyword.other.package.scala
# ^ source.scala meta.package.scala
# ^^ source.scala meta.package.scala entity.name.package.scala
# ^^^ source.scala meta.package.scala
Expand All @@ -2306,7 +2306,7 @@
#^ source.scala punctuation.section.block.end.scala
>
>package a.b {
#^^^^^^^ source.scala meta.package.scala keyword.other.import.scala
#^^^^^^^ source.scala meta.package.scala keyword.other.package.scala
# ^ source.scala meta.package.scala
# ^ source.scala meta.package.scala entity.name.package.scala
# ^ source.scala meta.package.scala punctuation.definition.package
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/fast-definitions.test.scala
Original file line number Diff line number Diff line change
Expand Up @@ -41,5 +41,5 @@
// ^^^ keyword.declaration.scala

package object
// ^^^^^^^ keyword.other.scoping.scala
// ^^^^^^^ keyword.other.package.scala
// ^^^^^^ keyword.declaration.scala