Fix quoted with spaces #250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
fix-quoted-with-spaces-2
branch
from
370c4b8 to
15a17db
Compare
tgodzik
approved these changes
Feb 10, 2023
nicolasstucki
force-pushed
the
fix-quoted-with-spaces-2
branch
from
15a17db to
bb5e498
Compare
|
@tgodzik I had to rebase to fix some conflicts. Could you have a quick look before merging? |
tgodzik
reviewed
Feb 10, 2023
| '{ 2 } | ||
| // ^^ punctuation.section.block.begin.scala | ||
| // ^ keyword.control.flow.staging.scala |
There was a problem hiding this comment.
Actually, should { have some kind of scope like in imports/exports? (for example we have meta.export.scala meta.export.selector.scala meta.bracket.scala) Or it doesn't really matter since braces are anyway interpreted correctly?
There was a problem hiding this comment.
{ have punctuation.section.block.begin.scala and [ have meta.bracket.scala.
I updated the tests
Syntax for quotes and symbols overlap. We can tag these as symbols and quotes at the same time.
nicolasstucki
force-pushed
the
fix-quoted-with-spaces-2
branch
from
bb5e498 to
cd24dc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #227