bugfix: Remove entity.other.inherited-class.scala #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, symbol in inheritance clause would be treated differently than outside it. Now, they are all treated the same. There are three reasons for that change: - most themes don't have a specific color for `entity.other.inherited-class.scala` and it would end up the same color as string - there is no reason to show the same symbol with different color aside from definition/declaration - there is no sensible way to handle `derives A, B, C` or `extends A, B, C` and the first `A` would be colored differently Fixes scala#239
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, symbol in inheritance clause would be treated differently than outside it. Now, they are all treated the same.
There are three reasons for that change:
entity.other.inherited-class.scalaand it would end up the same color as stringderives A, B, Corextends A, B, Cand the firstAwould be colored differentlyFixes #239