Remove extensionKind so that other extensions can depend on scala-syntax via SSH/WSL2

[tgodzik]

Based on feedback in microsoft/vscode#128375 (comment)

[MaximeKjaer]

Just to make sure I understand the problem correctly: Metals runs on the remote machine, and needs this extension in the remote workspace as well. And currently, since extensionKind doesn't contain workspace, this extension isn't available on the remote machine. Is that correct?

In either case, this change seems okay to me. A bit of history around this field:

• Make the extension available for the VS Live Share web client #199 requested support for web extensions
• In Add support for web extension #200, I said we probably shouldn't set workspace, because I thought that it would be better to run highlighting locally -- but I didn't consider other extensions that might depend on this one.
• The fix in Add support for web extension #200 ended up not working, because web extensions were not stable and fully documented yet

[tgodzik]

Just to make sure I understand the problem correctly: Metals runs on the remote machine, and needs this extension in the remote workspace as well. And currently, since extensionKind doesn't contain workspace, this extension isn't available on the remote machine. Is that correct?

So in my opinion it's really a bug, but it seems that Metals is validated on remote, where scala-syntax is not enabled as it's installed locally, so since the last version VS Code will disable the extension.

Haskell syntax doesn't declare the extensionKind at all and it all seems to work well.

[MaximeKjaer]

I see, thank you for the explanation @tgodzik ! Let's get this merged and release a new version.

[tgodzik]

I see, thank you for the explanation @tgodzik ! Let's get this merged and release a new version.

Thanks!