upgrade vsce to 1.93.0 #207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motivation: this also upgrades underscore, which Dependabot has been sending us a security alert about (CVE-2021-23358)
|
note that I have no idea what I'm doing here, I'm just blindly trying to get the security alert to go away. I bumped the vsce version in package.json and ran hopefully somebody who actually knows their way around this repo can decide if this is actually mergeable...? |
tgodzik
reviewed
Jun 23, 2021
| @@ -53,7 +53,7 @@ | |||
| "rimraf": "^3.0.2", | |||
| "ts-node": "^9.0.0", | |||
| "typescript": "^4.0.2", | |||
| "vsce": "^1.79.5", | |||
| "vsce": "^1.93.0", | |||
There was a problem hiding this comment.
It should be ok to upgrade, we have never had any issues with vsce in the Metals extension.
tgodzik
approved these changes
Jun 23, 2021
MaximeKjaer
approved these changes
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: this also upgrades underscore, which Dependabot has been sending us a security alert about (CVE-2021-23358)