Skip to content

Change idempotent as seen from #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 21, 2015

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Dec 11, 2015

Review by @smarter? Only the last commit is new.

@smarter
Copy link
Member

smarter commented Dec 18, 2015

Otherwise LGTM but I'm wondering if asSeenFrom being idempotent avoids some bugs/helps with something, or if you just thought it was a useful thing to do in general?

Let asSeenFrom generate a marker annotated type
for any unsafe instantiation. Then cleanup in
typedSelect.
@odersky odersky force-pushed the change-idempotent-asSeenFrom branch from be9faa8 to 5103f17 Compare December 21, 2015 17:02
@odersky
Copy link
Contributor Author

odersky commented Dec 21, 2015

Rebased on master

odersky added a commit that referenced this pull request Dec 21, 2015
@odersky odersky merged commit 08e3f76 into scala:master Dec 21, 2015
OlivierBlanvillain pushed a commit to OlivierBlanvillain/dotty that referenced this pull request Dec 12, 2016
@allanrenucci allanrenucci deleted the change-idempotent-asSeenFrom branch December 14, 2017 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants