Move s.u.FromString to s.u.CommandLineParser.FromString. #9988
Conversation
There was a problem hiding this comment.
Hello, and thank you for opening this PR! 🎉
All contributors have signed the CLA, thank you! ❤️
Commit Messages
We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).
Please stick to these guidelines for commit messages:
- Separate subject from body with a blank line
- When fixing an issue, start your commit message with
Fix #<ISSUE-NBR>:- Limit the subject line to 72 characters
- Capitalize the subject line
- Do not end the subject line with a period
- Use the imperative mood in the subject line ("Add" instead of "Added")
- Wrap the body at 80 characters
- Use the body to explain what and why vs. how
adapted from https://chris.beams.io/posts/git-commit
Have an awesome day! ☀️
There are many competing ways to parse things. `FromString` is tailored for command-line parsing. As such we should not expose it with a general name like `scala.util.FromString`. Instead, we move it inside `CommandLineParser` to make it clear that it is meant for command-line parsing.
sjrd
force-pushed
the
move-commandlineparser-fromstring
branch
from
589acad to
854877b
Compare
|
Updated with a rebase + executing |
|
idempotency test timed out in windows ci - its usually pretty flaky, should this merge? - or do we need to put a deprecated type alias |
|
Re-running ... |
|
Well this time the Windows bootstrapped build passed, but the community build job refused to even start ... |
|
I restarted the CI runner which was stuck, restarting this job too and hopefully it'll work now. |
There are many competing ways to parse things.
FromStringis tailored for command-line parsing. As such we should not expose it with a general name likescala.util.FromString. Instead, we move it insideCommandLineParserto make it clear that it is meant for command-line parsing.