make fromOrdinal public and always available

[bishabosha]

fromOrdinal exists on the companion object of an enum and is always defined, even if there are no value cases

[bishabosha]

tests are passing @sjrd is it correct that the fromOrdinal method should always be generated

[sjrd]

TBH I don't know. I have no recollection of what we discussed about fromOrdinal, and I haven't written down anything about that in my notes :(

[bishabosha]

Perhaps it was only if there there is at least one value :/ but I suppose this is meant to be low level for serialisation so it may be simpler to say its always there, as dual to def ordinal, which is always there for the same reason (as long as Mirror can be generated)

[sjrd]

Perhaps it was only if there there is at least one value :/

No, it's probably always. The other possibilities do not make sense.

What I'm not sure is whether we actually decided to make this public. But if we did, then it should definitely be always.

[bishabosha]

What I'm not sure is whether we actually decided to make this public.

its supposed to be the method thats available for an arbitrary serialisation framework so I would assume external access is required

[bishabosha]

what should happen with this?

[sjrd]

I guess it should be merged.